CodeQL 11: chore(tests): replace Returns((T?)null) casts with ReturnsNull()#197
Open
rlorenzo wants to merge 3 commits into
Open
CodeQL 11: chore(tests): replace Returns((T?)null) casts with ReturnsNull()#197rlorenzo wants to merge 3 commits into
rlorenzo wants to merge 3 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (18)
📝 WalkthroughWalkthroughSeventeen test files across the codebase are updated to use NSubstitute's ChangesNSubstitute ReturnsNull() Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
=======================================
Coverage 42.96% 42.96%
=======================================
Files 877 877
Lines 51468 51468
Branches 4802 4802
=======================================
Hits 22113 22113
Misses 28831 28831
Partials 524 524
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…051) PR-scoped gate flagged line 183 as a new xUnit1051 warning because '.ReturnsNull()' shifted git blame to this commit. The underlying FindAsync(object?[]?) call lacked a CancellationToken arg. Use the overload that accepts both, matched via Arg.Any<CancellationToken>().
Contributor
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes ~19
cs/useless-upcastalerts intest/**by replacing the NSubstitute pattern.Returns((SomeType?)null)with the dedicated.ReturnsNull()extension fromNSubstitute.ReturnsExtensions.Why
The explicit
(T?)nullcast existed because the bare.Returns(null)call is ambiguous between NSubstitute'sReturns<T>(T)andReturns<T>(Func<CallInfo, T>)overloads, but the cast itself trips thecs/useless-upcastrule (CodeQL sees the receiver's return type, so the cast is "redundant from the type system's POV")..ReturnsNull()is the canonical NSubstitute idiom for this case - it disambiguates without a cast and makes the test intent clearer.Files (18)
Each file got a
using NSubstitute.ReturnsExtensions;added.Context
Eleventh in the
CodeQL N:cleanup series. Earlier task #9 had marked these as wontfix-by-design - that was wrong.ReturnsNull()is the correct fix.Test plan
npm run test:backend- 1946 tests passing