Skip to content

CodeQL 15: chore(tests): narrow catch(Exception) to specific types in test helpers #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlorenzo wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −5
Open

CodeQL 15: chore(tests): narrow catch(Exception) to specific types in test helpers #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acd9bd1
chore(tests): narrow catch(Exception) to specific types in test helpers
rlorenzo May 13, 2026
33c47fb
chore(resharper): drop redundant namespace qualifiers in test catch f…
rlorenzo May 13, 2026
c72b48f
Merge branch 'main' into codeql/15-pdf-select-conversion
rlorenzo May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/CTS/AssessmentControllerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ private static bool IsForbidResult<T>(ActionResult<T> a)
Assert.True(result != null || forbidResult != null);

}
catch (Exception)
catch (Xunit.Sdk.XunitException)
{
return false;
}
Expand All @@ -279,7 +279,7 @@ private static bool IsNotFoundResult<T>(ActionResult<T> a)
var result = a.Result as NotFoundResult;
Assert.Equal((int)HttpStatusCode.NotFound, result?.StatusCode);
}
catch (Exception)
catch (Xunit.Sdk.XunitException)
{
return false;
}
Expand Down
5 changes: 3 additions & 2 deletions test/ClinicalScheduler/EmailNotificationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
using Microsoft.Data.SqlClient;
using Microsoft.EntityFrameworkCore;
using NSubstitute;
using NSubstitute.ExceptionExtensions;
Expand Down Expand Up @@ -281,7 +282,7 @@ await _context.Persons.AddAsync(new Models.ClinicalScheduler.Person
{
result = await _service.RemoveInstructorScheduleAsync(savedSchedule.InstructorScheduleId);
}
catch (Exception ex)
catch (Exception ex) when (ex is InvalidOperationException or DbUpdateException or SqlException or OperationCanceledException)
{
caughtException = ex;
System.Console.WriteLine($"Exception caught: {ex.GetType().Name}: {ex.Message}");
Expand Down Expand Up @@ -463,7 +464,7 @@ await _context.Persons.AddAsync(new Models.ClinicalScheduler.Person
{
result = await _service.RemoveInstructorScheduleAsync(savedPrimarySchedule.InstructorScheduleId);
}
catch (Exception ex)
catch (Exception ex) when (ex is InvalidOperationException or DbUpdateException or SqlException or OperationCanceledException)
{
caughtException = ex;
System.Console.WriteLine($"Exception caught: {ex.GetType().Name}: {ex.Message}");
Expand Down
2 changes: 1 addition & 1 deletion test/ClinicalScheduler/RotationServiceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ private void SeedTestData()
}
_context.SaveChanges();
}
catch (Exception ex)
catch (Exception ex) when (ex is DbUpdateException or InvalidOperationException)
{
// Log the exception and provide a clear error message for debugging
Console.WriteLine($"Error seeding test data: {ex.Message}");
Expand Down
Loading