Implementation of timestamps in chat#153
Open
1strangequark wants to merge 3 commits into
Open
Conversation
added 3 commits
January 21, 2020 23:26
Added a small if statement to check if the user has typed in a valid @ucla.edu email address. If not, it delivers an error message telling them to use their @ucla.edu email.
Implimented timestamps, which were already stored in the messages object. Each timestamp looks at the timestamp above it and only displays itself if there has been at least a 5 minute gap in-between messages.
Added some comments to help better explain the functionality of the timestamps within the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full implementation of timestamps in the chat. Each timestamp is added during the cell generation process of each chat cell. The timestamp info is grabbed from the already existing information and is applied as gray text next to the chat bubbles. The function decideToDisplayTimestamp() then decides whether to display the timestamp depending on whether the previous message in the chat has a timestamp at least 300 seconds prior (Thus meaning that a timestamp is not displayed for every single message but only messages after a period of no interaction)