Add proper ion & electron equilibration#4450
Open
chris-ashe wants to merge 37 commits into
Open
Conversation
…bles and adjust calculation function
…nces in physics models and tests
…usion reactions and tests
…d update references across the codebase
…references across the codebase
…ntributions to heating and loss calculations
…bration_vol_avg_mw and update references across the codebase
…nsport power calculations into a new method
…ty-weighted averages
…article contributions
…pdate related calculations
…onsitency and add derivation to documentation
… and improve clarity
…mentation and validation checks
… for electrons and ions
…ext and update related calculations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the plasma power balance modeling and visualization, focusing on distinguishing between global and species (ion/electron) energy constraints, adding new user controls for confinement time ratios, and enhancing documentation and plotting of equilibration times.
Summary of most important changes:
Physics Model and Documentation Enhancements
plasma_power_balance.md,plasma_confinement.md, anddetailed_physics.mdto clearly distinguish between global plasma power balance and species (ion/electron) power balances, including the mathematical formulations, solver recommendations, and new explanations for ion-electron equilibration time and power.Input and Constraint Handling
f_t_fuel_ion_electron_energy_confinementto allow users to set the ratio of ion to electron energy confinement times, and updated the input validation to prevent simultaneous activation of conflicting power balance constraints (icc=2,icc=3,icc=4).Visualization and Plotting Improvements
τ_E,τ_e,τ_i), their ratios, and thermal energies for ions and electrons.Checklist
I confirm that I have completed the following checks: