docs: fix stale MaxRetries comment on CloudflareRetriever#77
Merged
Conversation
The struct field comment still said "defaults to 3, set to -1 to disable", but the default substitution was removed in the Cloudflare routing PR — zero value now means no retries and the production default (2) is wired via the exported CFDefaultMaxRetries constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the nit from umputun's review on #73 (merged before the fix landed).
The
MaxRetriesstruct field comment still said defaults to 3, set to -1 to disable retries, but the default substitution was removed as part of the routing PR — the zero value now means no retries, and the production default (2) is wired via the exportedCFDefaultMaxRetriesconstant. Comment now matches the godoc on theRetrievemethod.One-line change.