CLDR-19353 Revise display of tags (chits)#5796
Open
btangmu wants to merge 2 commits into
Open
Conversation
-Make the borders thicker and darker -Show some additional characters (quotes/apostrophes/primes) as tags but do not include them in the Insert menu -Add documentation for the additional characters in getting-started/guide.md -Minor related refactoring and comments -(Unrelated:) Suppress distracting console warnings for intentionally invalid locale IDs in TestCldrLocales
macchiati
requested changes
Jun 3, 2026
Member
macchiati
left a comment
macchiati
left a comment
There was a problem hiding this comment.
Looks good. I think we want the border to be a bit more eye catching , like dark blue. Ow, ok.
Member
Author
The 2nd commit changes it from black to midnightblue. Per web search, "MidnightBlue (#191970) is actually lighter and less saturated than DarkBlue (#00008B)" and on a cyan background "Its muted 64% saturation structure stops the layout from looking too jarringly blocky." |
Member
Author
|
macchiati
requested changes
Jun 4, 2026
| in the Insert menu. They are not invisibles, so the characters themselves, rather | ||
| than their names, are displayed in the tags. Users can see their names by hovering. | ||
|
|
||
| ◦ " U+0022 QUOTATION MARK |
Member
There was a problem hiding this comment.
Either we should have both or neither of these:
- U+0022 QUOTATION MARK
- U+0027 APOSTROPHE
I'd lean towards neither.
(This was probably my fault in supplying the list.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Make the borders thicker and darker
-Show some additional characters (quotes/apostrophes/primes) as tags but do not include them in the Insert menu
-Add documentation for the additional characters in getting-started/guide.md
-Minor related refactoring and comments
-(Unrelated:) Suppress distracting console warnings for intentionally invalid locale IDs in TestCldrLocales
CLDR-19353
ALLOW_MANY_COMMITS=true