Skip to content

update pre-commit hooks and development tooling docs - #11618

Closed
xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:pre-commit
Closed

update pre-commit hooks and development tooling docs#11618
xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:pre-commit

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Apr 3, 2026

Copy link
Copy Markdown
Contributor
  • Remove the rust-clippy pre-commit hook as it is not fast enough to be usable and fails on macOS.
  • Update the development tooling docs as parts were outdated or unclear.

Justification

In my opinion, it's far more likely for a contributor to forget to update the fuzz lockfile than run clippy. There is more value if the hooks run fast and cover easily overlooked issues.

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)

@xtqqczze

This comment was marked as resolved.

@sylvestre

Copy link
Copy Markdown
Contributor

sorry but i do value the clippy run

@oech3

oech3 commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

We can skip this if --print host-tuple contains macos instead of removing.

@xtqqczze

xtqqczze commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

I will try to progress #11016 in order fix clippy for macOS.

@xtqqczze
xtqqczze marked this pull request as draft April 9, 2026 19:00
@xtqqczze

Copy link
Copy Markdown
Contributor Author

I still think the pre-commit hook with Clippy is be too slow to be usable. A pre-push hook on the other hand would be much more useful.

There are also fundamental issues with pre-commit hooks, see https://jyn.dev/pre-commit-hooks-are-fundamentally-broken/.

@xtqqczze xtqqczze closed this May 24, 2026
@xtqqczze
xtqqczze deleted the pre-commit branch May 24, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants