Skip to content

dd: fix stdout output - #13066

Open
zhw2101024 wants to merge 2 commits into
uutils:mainfrom
zhw2101024:fix_stdout_output
Open

dd: fix stdout output#13066
zhw2101024 wants to merge 2 commits into
uutils:mainfrom
zhw2101024:fix_stdout_output

Conversation

@zhw2101024

Copy link
Copy Markdown
Contributor

Fixes #11557
Added DdError since io::Result as return type is not enough for this fix.
Many changes to pass the clippy checks, please tell me if there's better solutions.

Comment thread src/uu/dd/src/dd.rs Outdated
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)

Comment thread src/uu/dd/src/dd.rs Outdated
@cakebaker cakebaker changed the title Fix stdout output dd: fix stdout output Jun 24, 2026
@oech3

oech3 commented Jun 24, 2026 via email

Copy link
Copy Markdown
Contributor

Comment thread src/uu/dd/src/dd.rs Outdated
Comment thread src/uu/dd/src/dd.rs Outdated
Comment thread src/uu/dd/src/dd.rs Outdated
@zhw2101024

Copy link
Copy Markdown
Contributor Author

Hello, are there more concerns about this change?

@zhw2101024
zhw2101024 force-pushed the fix_stdout_output branch from 31993a7 to a1592a6 Compare July 6, 2026 04:43
@zhw2101024
zhw2101024 force-pushed the fix_stdout_output branch 2 times, most recently from a4927e8 to 31d071b Compare July 17, 2026 18:03
@zhw2101024
zhw2101024 force-pushed the fix_stdout_output branch 2 times, most recently from aa9a817 to 047d152 Compare July 30, 2026 10:18
@codspeed-hq

codspeed-hq Bot commented Aug 3, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 3.98%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 343 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cksum_default 38.2 ms 39.8 ms -4.02%
Simulation cksum_multiple_files 58.3 ms 60.7 ms -3.95%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing zhw2101024:fix_stdout_output (8b4c801) with main (37b1d11)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dd of=/dev/stdout cause Illegal seek

2 participants