dd: fix stdout output - #13066
Conversation
|
GNU testsuite comparison: |
e82a5ee to
13f316c
Compare
|
We don't aim generating 100% same error message with GNU. But exit code should be same and should not panic.
|
13f316c to
cb4dfeb
Compare
cb4dfeb to
31993a7
Compare
|
Hello, are there more concerns about this change? |
31993a7 to
a1592a6
Compare
a4927e8 to
31d071b
Compare
aa9a817 to
047d152
Compare
047d152 to
8b4c801
Compare
Merging this PR will degrade performance by 3.98%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | cksum_default |
38.2 ms | 39.8 ms | -4.02% |
| ❌ | Simulation | cksum_multiple_files |
58.3 ms | 60.7 ms | -3.95% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing zhw2101024:fix_stdout_output (8b4c801) with main (37b1d11)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Fixes #11557
Added DdError since io::Result as return type is not enough for this fix.
Many changes to pass the clippy checks, please tell me if there's better solutions.