install: add error with -d when an argument is not dir#13175
Merged
Conversation
Contributor
Author
|
I'll check the issues and re-push. |
Contributor
|
Thanks! |
Contributor
Author
|
Your welcome! Hope the failing issues were not caused by the changes but from the CI/CD pipeline (didn't have enough time these days to check them thoroughly). |
Contributor
|
The failing jobs were unrelated to the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13170
To solve it, we check inside were the directories are created if an existing path is a file and if so we
show!(...)the new error message. The error is printed for each file passed in arguments and the dir arguments are created normally (as GNU install does).