Skip to content

cp: dedup nofollow #13186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oech3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cp: dedup nofollow #13186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/uu/cp/src/platform/linux.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,14 @@ fn clone<P>(source: P, dest: P, fallback: CloneFallback, nofollow: bool) -> std:
where
P: AsRef<Path>,
{
let src_file = open_source(&source, nofollow)?;
let dst_file = create_dest_restrictive(&dest, false)?;
if ioctl_ficlone(dst_file, src_file).is_err() {
let mut src_file = open_source(&source, nofollow)?;
let mut dst_file = create_dest_restrictive(&dest, false)?;
if ioctl_ficlone(&dst_file, &src_file).is_err() {
// todo: use fd instead of Path to avoid TOCTOU race
return match fallback {
CloneFallback::Error => Err(std::io::Error::last_os_error()),
CloneFallback::FSCopy => fs_copy(source, dest, nofollow),
// already nofollow
CloneFallback::FSCopy => buf_copy::copy_stream(&mut src_file, &mut dst_file),
CloneFallback::SparseCopy => sparse_copy(source, dest, nofollow),
CloneFallback::SparseCopyWithoutHole => {
sparse_copy_without_hole(source, dest, nofollow)
Expand Down
Loading