Skip to content

sum: remove .is_dir() overhead#13218

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:sum-is-dir
Open

sum: remove .is_dir() overhead#13218
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:sum-is-dir

Conversation

@oech3

@oech3 oech3 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Closes #12947 . .is_dir() is really bad idea even it does not cause any security incident.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!

@codspeed-hq

codspeed-hq Bot commented Jun 30, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.67%

❌ 1 regressed benchmark
✅ 326 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_ascii_c_locale 16 ms 16.7 ms -4.67%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:sum-is-dir (d1dfba6) with main (b76d615)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 marked this pull request as ready for review June 30, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sum: path.is_dir() has overhead of additional stat

1 participant