Skip to content

fix(timeout, uucore): use sigwait and timers for waiting#13237

Draft
Alonely0 wants to merge 1 commit into
uutils:mainfrom
Alonely0:fix-timeout-latency
Draft

fix(timeout, uucore): use sigwait and timers for waiting#13237
Alonely0 wants to merge 1 commit into
uutils:mainfrom
Alonely0:fix-timeout-latency

Conversation

@Alonely0

@Alonely0 Alonely0 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Does away with the current waiting loop for great good.

I had to use the nix crate for signals (even if we're trying to move away from it) because rustix has no plans to support the sigset APIs. I also had to manually use libc for the timers because nix has not caught up to redox, although at least it's very self-contained trivially safe.

Fixes: #9099, #11615 (and other duplicates, if any). All other open timeout issues should be re-assessed since it's a big backend change.

Opened as draft until I nail down platform support and an intermittent GNU test suite failure.

@Alonely0 Alonely0 force-pushed the fix-timeout-latency branch 2 times, most recently from a44e1dc to 2fd27a1 Compare July 1, 2026 03:44
@codspeed-hq

codspeed-hq Bot commented Jul 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 327 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing Alonely0:fix-timeout-latency (968dc25) with main (bc3a413)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/dd/no-allocate is now passing!

@Alonely0 Alonely0 force-pushed the fix-timeout-latency branch 17 times, most recently from c7dfbe9 to 968dc25 Compare July 1, 2026 14:58
@Alonely0 Alonely0 force-pushed the fix-timeout-latency branch from 968dc25 to 8563627 Compare July 1, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timeout is slow

1 participant