fix(timeout, uucore): use sigwait and timers for waiting#13237
Draft
Alonely0 wants to merge 1 commit into
Draft
Conversation
a44e1dc to
2fd27a1
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
|
GNU testsuite comparison: |
c7dfbe9 to
968dc25
Compare
968dc25 to
8563627
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does away with the current waiting loop for great good.
I had to use the nix crate for signals (even if we're trying to move away from it) because rustix has no plans to support the sigset APIs. I also had to manually use libc for the timers because nix has not caught up to redox, although at least it's very self-contained trivially safe.
Fixes: #9099, #11615 (and other duplicates, if any). All other open timeout issues should be re-assessed since it's a big backend change.
Opened as draft until I nail down platform support and an intermittent GNU test suite failure.