uucore: sort dependencies that are no longer pinned - #13729
Open
xtqqczze wants to merge 1 commit into
Open
Conversation
cakebaker
reviewed
Aug 3, 2026
Comment on lines
47
to
49
| # Not optional: os_display already pulls unicode-width into every uucore build, | ||
| # so making it a direct dependency here is free and keeps char_width available | ||
| # on all targets (a feature-gated optional dep failed to activate on wasm). |
Contributor
There was a problem hiding this comment.
I think this comment belongs to unicode-width.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.