ptx: accept invalid UTF-8 input and trailing backslash regexps - #14032
Open
sylvestre wants to merge 1 commit into
Open
ptx: accept invalid UTF-8 input and trailing backslash regexps#14032sylvestre wants to merge 1 commit into
sylvestre wants to merge 1 commit into
Conversation
sylvestre
force-pushed
the
fix-gnu-ptx-overrun
branch
from
August 19, 2026 16:53
37fe2f6 to
5a00998
Compare
49 tasks
ptx aborted with "stream did not contain valid UTF-8" on input that is not valid UTF-8, while GNU ptx operates on bytes and processes it fine. Input is now read as bytes and decoded lossily. Additionally, a regexp ending in a lone backslash (e.g. -S 'foo\') was rejected by the regex crate as an incomplete escape sequence, whereas GNU treats it as a literal backslash. Such a trailing backslash is now doubled before compiling the pattern, for both -S and -W. Should make test tests/ptx/ptx-overrun.sh pass uutils#13841
sylvestre
force-pushed
the
fix-gnu-ptx-overrun
branch
from
August 19, 2026 17:01
5a00998 to
2d2cdf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ptx aborted with "stream did not contain valid UTF-8" on input that is not valid UTF-8, while GNU ptx operates on bytes and processes it fine. Input is now read as bytes and decoded lossily.
Should make test tests/ptx/ptx-overrun.sh pass
#13841