sort: reject --batch-size arguments above the fd soft limit - #14033
Open
sylvestre wants to merge 1 commit into
Open
sort: reject --batch-size arguments above the fd soft limit#14033sylvestre wants to merge 1 commit into
sylvestre wants to merge 1 commit into
Conversation
sort only validated --batch-size against the file descriptor rlimit when the argument did not even fit in a usize. A value such as 20 with a soft limit of 19 was silently accepted, while GNU sort exits with status 2 and reports the maximum usable value. Compare the parsed value with the soft limit minus the three descriptors that are always taken by stdin, stdout and stderr, and reuse the existing "too large"/"maximum --batch-size argument with current rlimit" messages for both the overflow and the out-of-range cases. PR uutils#11961 (deduplicating file descriptors during merge) targets a different part of the problem and does not touch this validation. Should make test tests/sort/sort-merge-fdlimit.sh pass uutils#11961 uutils#13841
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sort only validated --batch-size against the file descriptor rlimit when the argument did not even fit in a usize. A value such as 20 with a soft limit of 19 was silently accepted, while GNU sort exits with status 2 and reports the maximum usable value.
Compare the parsed value with the soft limit minus the three descriptors that are always taken by stdin, stdout and stderr, and reuse the existing "too large"/"maximum --batch-size argument with current rlimit" messages for both the overflow and the out-of-range cases.
PR #11961 (deduplicating file descriptors during merge) targets a different part of the problem and does not touch this validation.
Should make test tests/sort/sort-merge-fdlimit.sh pass #11961
#13841