Skip to content

cmp: use .map_err#236

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:cmp-map_err
Jun 10, 2026
Merged

cmp: use .map_err#236
cakebaker merged 1 commit into
uutils:mainfrom
oech3:cmp-map_err

Conversation

@oech3

@oech3 oech3 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@oech3 oech3 marked this pull request as ready for review June 3, 2026 12:24
@codspeed-hq

codspeed-hq Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 5.46%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 25 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cmp_parser 5.6 µs 5.9 µs -5.46%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:cmp-map_err (5740d85) with main (f29e96c)

Open in CodSpeed

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

GNU diffutils testsuite comparison:

Test results comparison:
  Current:   TOTAL: 33 / PASSED: 0 / FAILED: 33 / SKIPPED: 0
  Reference: TOTAL: 33 / PASSED: 8 / FAILED: 21 / SKIPPED: 4

Changes from main branch:
  TOTAL: +0
  PASSED: -8
  FAILED: +12

New test failures (12):
  - basic
  - bignum
  - brief-vs-stat-zero-kernel-lies
  - bug-64316
  - cmp
  - diff3
  - help-version
  - large-subopt
  - strcoll-0-names
  - strip-trailing-cr
  - timezone
  - y2038-vs-32bit

marc-hb

This comment was marked as low quality.

@oech3

This comment was marked as resolved.

@marc-hb

marc-hb commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Need more coffee? Sincere apologies for the noise.

@oech3

oech3 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

No problem. Thankyou for reviewing.

@oech3 oech3 marked this pull request as draft June 4, 2026 14:48
@oech3 oech3 closed this Jun 8, 2026
@oech3 oech3 deleted the cmp-map_err branch June 8, 2026 15:42
@oech3

This comment was marked as low quality.

@oech3 oech3 restored the cmp-map_err branch June 9, 2026 17:33
@oech3 oech3 reopened this Jun 9, 2026
@oech3 oech3 marked this pull request as ready for review June 9, 2026 17:35
@cakebaker cakebaker merged commit dc9ca17 into uutils:main Jun 10, 2026
29 of 31 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@oech3 oech3 deleted the cmp-map_err branch June 10, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants