ci: polish the image-build retry loop#174
Merged
Merged
Conversation
Address review feedback on #173: - Don't sleep after the final build attempt (no retry follows it). - Forward the workflow-wide CARGO_NET_RETRY into the container with a bare '-e CARGO_NET_RETRY' instead of re-hardcoding the value, keeping a single source of truth.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a small follow-up improvement to the Docker-matrix CI workflow, tightening the retry loop behavior and removing duplication around CARGO_NET_RETRY so the workflow-wide setting remains the single source of truth.
Changes:
- Avoids sleeping after the final (3rd) failed
docker compose buildattempt by gating the backoff toattempt < 3. - Forwards the workflow-wide
CARGO_NET_RETRYintodocker compose runwith-e CARGO_NET_RETRYinstead of hard-coding=10.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up addressing the two Copilot comments on #173:
attempt < 3.CARGO_NET_RETRY— the container run hard-coded-e CARGO_NET_RETRY=10, duplicating the workflow-wideenvvalue. Now forwards the existing var with a bare-e CARGO_NET_RETRY.Verified locally: YAML parses;
-e CARGO_NET_RETRYpropagates the workflow value into the container.Refs #172, #173.