feat: Align grant registration with new gateway struct#150
Open
letonchanh wants to merge 3 commits into
Open
Conversation
Replace the legacy `grant: string` JSON blob + `fileIds: uint256[]` with first-class EIP-712 fields `scopes: string[]`, `grantVersion: uint256`, and `expiresAt: uint256`, and add `grantVersion` to GrantRevocation so the monotonic nonce defends both events against replay. Update the gateway client wire format and GET response shape (now carries `expiresAt`/`expired`/`paymentStatus`/`paidAt`/`paidBy`/`grantVersion`/ `fee`) to match data-gateway. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Findings
Verification
|
Add the GenericPayment EIP-712 typed-data and gateway-client wrappers for /v1/escrow/balance, /v1/escrow/deposit, and /v1/escrow/pay so a builder can settle a grant's registration + data-access fees before calling the Personal Server. Adds `dataPortabilityEscrow` to the contracts config (so existing fixtures gain the field) and a NATIVE_VANA_ASSET sentinel for the native-asset case. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add primitives for funding the escrow balance from a wallet —
buildDepositNativeRequest / buildDepositTokenRequest return the
raw {to, data, value?} request object for any tx-submission stack
(viem, ethers, wallet-rpc, MPC, Safe). The credited `account` is
encoded in calldata, so a third party can fund someone else's escrow.
Add an e2e test that wires the deposit + payment helpers through a
real viem WalletClient against an in-memory L1 (custom RPC transport)
and a fetch-mocked gateway that decodes the same calldata via
ESCROW_DEPOSIT_ABI and recovers the GenericPayment signer with
recoverTypedDataAddress — the same cryptographic checks the real
gateway runs. Covers happy path, 402 insufficient-balance, and 409
nonce-replay.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the legacy
grant: stringJSON blob +fileIds: uint256[]with first-class EIP-712 fieldsscopes: string[],grantVersion: uint256, andexpiresAt: uint256, and addgrantVersionto GrantRevocation so the monotonic nonce defends both events against replay. Update the gateway client wire format and GET response shape (now carriesexpiresAt/expired/paymentStatus/paidAt/paidBy/grantVersion/fee) to match data-gateway.