Update to vcon-core-01 compliance#4
Closed
howethomas wants to merge 3 commits into
Closed
Conversation
- Update types.ts with full vcon-core-01 interfaces (DialogType, DialogDisposition, Encoding, etc.) - Update Dialog class with DIALOG_TYPES, DISPOSITIONS, VALID_ENCODINGS constants - Update Attachment class with new params-based constructor and validation - Update Party class with sip, did, timezone fields and validation methods - Update Vcon class with extension support, groups, and enhanced API - Add comprehensive tests for all new features (61 tests passing) - Add 3 tutorial examples: text-chat, call-recording, video-conference - Update README.md with complete API reference and tutorials - Add CLAUDE.md for AI assistant instructions Breaking changes: - Encoding type now only allows 'base64url', 'json', 'none' (not 'base64') - Attachment constructor now takes params object instead of positional args - Dialog type values are now 'recording', 'text', 'transfer', 'incomplete' 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Core Library
Documentation
Breaking Changes
Test plan
npm test)npm run build)npm run examples)🤖 Generated with Claude Code
Note
Implements full vcon-core-01 compliance across types and classes (new encodings, fields, validation, and APIs), adds examples and docs, and expands tests and scripts.
src/types.ts: Add comprehensive spec-aligned types (DialogType,DialogDisposition,Encoding,SessionId,Group,Redacted/Amended),VCON_VERSION, and richerParty/CivicAddress.src/dialog.ts: New constants (DIALOG_TYPES,DISPOSITIONS,VALID_ENCODINGS), switch tomediatype, allowpartiesint or array, addaddExternalData/addInlineData, helpers (isRecording/isText/...), andvalidate().src/attachment.ts: Params-based constructor, support inline/external data with helpers,VALID_ENCODINGS,toDict()date ISO, andvalidate().src/party.ts: Addsip,did,timezone, helpers (hasIdentifier,getPrimaryIdentifier),validate(), andPartyHistoryimprovements.src/vcon.ts: RFC3339 timestamps as strings, extension framework (addExtension,addCriticalExtension,hasExtension),addGroup, updatedaddAttachment/addAnalysis, getters/setters forsubject/meta/redacted/amended, exportvcondefault toVCON_VERSION.src/index.ts: Export new types/constants.base64url,json,none(removebase64).Attachmentnow takes a params object.recording,text,transfer,incomplete; prefermediatypeovermimetype.README.md: Overhauled with API reference, compliance notes, and usage.examples/01-text-chat.ts,02-call-recording.ts,03-video-conference.tswith new npm scripts inpackage.json.CLAUDE.md: Project overview and guidance.Written by Cursor Bugbot for commit df27da7. Configure here.