feat(api): add count param to /dlq/reprocess (CON-575)#183
Merged
Conversation
Bound work per call so large DLQs don't time out at proxies and callers can drive the drain loop client-side. Default 1000, max 100k. Response shape unchanged (still an int count of items moved).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
countquery param toPOST /dlq/reprocessto bound work per call (default 1000, max 100k).while ...:drain into a boundedfor _ in range(count): ...loop, breaking early when the DLQ empties.Linear: CON-575
Why
Today's incident: cleaning up a ~4M DLQ couldn't use this endpoint — at ~1600 items/sec sequential LPOP+RPUSH that's ~42 min of one HTTP request, well past every proxy timeout (Traefik 60s, browsers, internal LBs). The drain had to be done out-of-band via a Python sidecar using Lua LMOVE batches.
countmoves the loop from server to client: each call is bounded and snappy, the client drives the drain (while r > 0: POST ...&count=10000), progress is observable per response, no timeouts.Backward compatibility
countis optional with default.JSONResponse(content=<int>).countwork unchanged — they just get bounded responses.Test plan
pytest common/tests/test_api_branches.py common/tests/test_api.py -v— 21 passed.count=3against an unbounded mock drains exactly 3 items.