fix: keep task logger messages static#236
Open
EfeDurmaz16 wants to merge 2 commits into
Open
Conversation
Contributor
|
@EfeDurmaz16 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| .filter((line) => line.trim()) | ||
| for (const line of lines) { | ||
| logger.info(`[SERVER] ${line}`).catch(() => {}) | ||
| logger.info('Development server produced output').catch(() => {}) |
Contributor
There was a problem hiding this comment.
Identical static log message 'Development server produced output' is emitted once per line of server output instead of once per chunk in start-sandbox/route.ts and lib/sandbox/creation.ts, causing log spam with no useful information.
Author
|
Updated this branch with a focused follow-up for the restart-dev log spam review. Change:
Verification:
Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm check:task-logsto catch future non-literal TaskLogger messagesCloses #58.
Verification
pnpm check:task-logspnpm type-check