test(slack): expand emulator coverage for emulate.dev 0.6.0 APIs#591
Open
oss-polar-bear wants to merge 2 commits into
Open
test(slack): expand emulator coverage for emulate.dev 0.6.0 APIs#591oss-polar-bear wants to merge 2 commits into
oss-polar-bear wants to merge 2 commits into
Conversation
Upgrade @emulators/* to 0.6.0 and add integration tests for DMs, reactions, fetch history, modals, scheduled messages, file uploads, member joins, and bookmarks against the in-process Slack emulator.
Contributor
|
@oss-polar-bear is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Expands Slack emulator integration test coverage by adding end-to-end round-trip tests for additional Slack APIs/events (views, reactions, DMs, scheduled messages, file uploads, bookmarks, and message fetching), and refactors Slack interactivity request helpers to support multiple interactivity payload types.
Changes:
- Refactor Slack interactivity request creation to a generic helper and add
view_submissionrequest generation. - Add multiple new Slack emulator integration tests covering views, reactions, DMs, scheduled messages, file uploads, bookmarks, and message fetching.
- Update emulator dependencies to
^0.6.0and expand bot token scopes used by the emulator tests.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/integration-tests/src/slack-utils.ts | Generalize signed Slack interactivity request creation; add view_submission payload + request helper. |
| packages/integration-tests/src/emulator/slack/views.test.ts | Add modal view open/update + view_submission delivery integration tests. |
| packages/integration-tests/src/emulator/slack/utils.ts | Expand bot scopes and add new emulator helper functions (reactions, triggers, joins, bookmarks, seeding). |
| packages/integration-tests/src/emulator/slack/scheduled-messages.test.ts | Add integration test for scheduling + canceling messages. |
| packages/integration-tests/src/emulator/slack/reactions-events.test.ts | Add integration test for reaction_added forwarding and handler behavior. |
| packages/integration-tests/src/emulator/slack/post-message.test.ts | Replace markdown-post test with chat.postEphemeral test asserting emulator storage. |
| packages/integration-tests/src/emulator/slack/oauth.test.ts | Strengthen OAuth assertions to validate bot user id format and stored bot user record. |
| packages/integration-tests/src/emulator/slack/member-joined-channel.test.ts | Add integration test for member_joined_channel via conversations.join. |
| packages/integration-tests/src/emulator/slack/file-upload.test.ts | Add integration test for external file upload flow and store assertions. |
| packages/integration-tests/src/emulator/slack/fetch-messages.test.ts | Add integration tests for channel history + threaded replies fetching. |
| packages/integration-tests/src/emulator/slack/dm-events.test.ts | Add integration test for DM open + inbound DM delivery and reply posting. |
| packages/integration-tests/src/emulator/slack/bookmarks.test.ts | Add integration test for bookmarks add/list API behavior via emulator. |
| packages/integration-tests/package.json | Bump emulator devDependencies to ^0.6.0. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix definite-assignment patterns in new integration tests, restore JSDoc placement for waitForDelivery, and default view_submission private_metadata to an empty string for Slack-realistic payloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade @emulators/* to 0.6.0 and add integration tests for DMs, reactions, fetch history, modals, scheduled messages, file uploads, member joins, and bookmarks against the in-process Slack emulator.