Skip to content

Add module.exports so it can be required using browserify#94

Closed
herpiko wants to merge 2 commits into
victorb:masterfrom
herpiko:npm-2
Closed

Add module.exports so it can be required using browserify#94
herpiko wants to merge 2 commits into
victorb:masterfrom
herpiko:npm-2

Conversation

@herpiko

@herpiko herpiko commented Oct 18, 2015

Copy link
Copy Markdown

No description provided.

@cetra3

cetra3 commented Feb 10, 2016

Copy link
Copy Markdown
Collaborator

Hi @herpiko,

I have a feeling this would break compatibility with non-browserify code, as module is not a defined function with vanilla javascript. Is there a more compatible way of doing this?

@zakhenry

zakhenry commented Apr 7, 2016

Copy link
Copy Markdown

@cetra3 I have implemented a more compatible export method in #115 which should close this PR

@herpiko

herpiko commented Apr 8, 2016

Copy link
Copy Markdown
Author

@xiphiaz Thank you. I'm sorry for this ugly PR. I'll close this.

@herpiko herpiko closed this Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants