Refactor: Add comprehensive type hints and fix search_title bug#75
Open
anzinmhd wants to merge 1 commit into
Open
Refactor: Add comprehensive type hints and fix search_title bug#75anzinmhd wants to merge 1 commit into
anzinmhd wants to merge 1 commit into
Conversation
- Implement type hints across core SDK (client, collection, video, editor, etc.) - Fix search_title in collection.py to correctly return List[Video] - Resolve TODO for Meeting type check in video.py - Handle circular imports using TYPE_CHECKING and forward references - Add unit tests for search_title and get_meeting verification - Ensure ruff and pytest compliance
Author
|
Hi everyone, I wanted to follow up on this PR. I’ve implemented PEP 484 type hints to improve IDE support and resolved a circular dependency issue that was impacting the core architecture. I’ve also added unit tests and verified the fix for search_title using pytest. I understand you are all very busy, but if you could find some time to review this, I’d love to hear your thoughts on these architectural improvements. I’m happy to make any adjustments based on your feedback!. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements enterprise-grade type hints across the core VideoDB Python SDK. It also fixes a structural bug in the
search_titlemethod and resolves a pendingTODOfor theMeetingtype check.Key Changes
client,collection,video,editor,rtstream,audio, etc.) to improve IDE support and prevent bugs.Collection.search_titleto returnList[Video]instead of raw dictionaries, ensuring consistency with the rest of the SDK.TODOinvideo.pyfor theMeetingclass type check.TYPE_CHECKINGblocks and string forward references.Verification (Proof)
tests/test_collection.pyandtests/test_video.pyto verify the fixes.ruff check .(0 errors).