Skip to content

fix: failing e2e tests after lindas next migration #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mburri wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: failing e2e tests after lindas next migration #2544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e00e4a3
fix: sorting spec - grisons has changed to graubünden
mburri Apr 10, 2026
720cb75
fix: use correct dataset url for red list, adjust test to changes in …
mburri Apr 10, 2026
77b2bf8
fix: remove misleading icon for last step
mburri Apr 10, 2026
95e6ddb
fix: add warmups to handle cold start issues on vercel deployments
mburri Apr 10, 2026
31781d0
fix: try with photovoltaikanlagen/10
mburri Apr 10, 2026
e80d75a
fix: attempt #1
mburri Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 121 additions & 16 deletions .github/workflows/performance-tests-pr.yaml
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions e2e/filter-position.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ const { test, expect } = setup();

test("Filters should be sorted by position", async ({ selectors, actions }) => {
await actions.chart.createFrom({
iri: "https://environment.ld.admin.ch/foen/UBD003002/6",
dataSource: "Int",
iri: "https://environment.ld.admin.ch/foen/ubd003001/10", // "Red List" of species
dataSource: "Prod",
});

await selectors.edition.drawerLoaded();
Expand All @@ -18,7 +18,7 @@ test("Filters should be sorted by position", async ({ selectors, actions }) => {
.getByLabelText("None");
await selectorLocator.click();

await actions.mui.selectOption("Status");
await actions.mui.selectOption("Status IUCN");

const panelLeft = await selectors.panels.drawer().within();
await panelLeft.findByText("Selected filters", undefined, {
Expand All @@ -45,6 +45,5 @@ test("Filters should be sorted by position", async ({ selectors, actions }) => {
"Endangered",
"Critically endangered",
"Regionally extinct",
"Extinct in the world",
]);
});
2 changes: 1 addition & 1 deletion e2e/sorting.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ test("Segment sorting with hierarchy", async ({
"Appenzell Ausserrhoden",
"Appenzell Innerrhoden",
"St Gallen",
"Grisons",
"Graubünden",
"Aargau",
"Thurgau",
"Ticino",
Expand Down
4 changes: 2 additions & 2 deletions k6/performance-tests/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[
{
"iri": "https://energy.ld.admin.ch/sfoe/bfe_ogd84_einmalverguetung_fuer_photovoltaikanlagen/9",
"label": "Photovoltaikanlagen/9",
"iri": "https://energy.ld.admin.ch/sfoe/bfe_ogd84_einmalverguetung_fuer_photovoltaikanlagen/10",
"label": "Photovoltaikanlagen/10",
"filters": {
"https://energy.ld.admin.ch/sfoe/bfe_ogd84_einmalverguetung_fuer_photovoltaikanlagen/Kanton": {
"type": "single",
Expand Down
13 changes: 10 additions & 3 deletions k6/performance-tests/graphql/DataCubeComponents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const variables = {

/** @type {import("k6/options").Options} */
export const options = {
iterations: 2,
iterations: 3,
};

const headers = {
Expand All @@ -51,6 +51,7 @@ export default function Components() {

const res = http.post(endpoint, JSON.stringify({ query, variables }), {
headers,
tags: { warmup: exec.scenario.iterationInTest === 0 ? "true" : "false" },
});

check(res, {
Expand All @@ -77,10 +78,16 @@ export default function Components() {
}

export function handleSummary(data) {
if (durationExceedsThreshold(data.metrics.http_req_duration.values.avg)) {
const warmupMetrics = data.metrics["http_req_duration{warmup:true}"];
const actualMetrics = data.metrics["http_req_duration{warmup:false}"];
const avgDuration = actualMetrics
? actualMetrics.values.avg
: data.metrics.http_req_duration.values.avg;

if (durationExceedsThreshold(avgDuration)) {
return {
stdout: `${Math.round(
(100 * data.metrics.http_req_duration.values.avg) /
(100 * avgDuration) /
metadata.queries.DataCubeComponents.expectedDuration
)}% – DataCubeComponents – ${cubeLabel}. `,
};
Expand Down
14 changes: 10 additions & 4 deletions k6/performance-tests/graphql/DataCubeMetadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const variables = {

/** @type {import("k6/options").Options} */
export const options = {
iterations: 2,
iterations: 3,
};

const headers = {
Expand All @@ -51,6 +51,7 @@ export default function Components() {

const res = http.post(endpoint, JSON.stringify({ query, variables }), {
headers,
tags: { warmup: exec.scenario.iterationInTest === 0 ? "true" : "false" },
});

check(res, {
Expand All @@ -74,11 +75,16 @@ export default function Components() {
}

export function handleSummary(data) {
if (durationExceedsThreshold(data.metrics.http_req_duration.values.avg)) {
const warmupMetrics = data.metrics["http_req_duration{warmup:true}"];
const actualMetrics = data.metrics["http_req_duration{warmup:false}"];
const avgDuration = actualMetrics
? actualMetrics.values.avg
: data.metrics.http_req_duration.values.avg;

if (durationExceedsThreshold(avgDuration)) {
return {
stdout: `${Math.round(
(100 * data.metrics.http_req_duration.values.avg) /
metadata.queries.DataCubeMetadata.expectedDuration
(100 * avgDuration) / metadata.queries.DataCubeMetadata.expectedDuration
)}% – DataCubeMetadata – ${cubeLabel}. `,
};
}
Expand Down
13 changes: 10 additions & 3 deletions k6/performance-tests/graphql/DataCubeObservations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const variables = {

/** @type {import("k6/options").Options} */
export const options = {
iterations: 2,
iterations: 3,
};

const headers = {
Expand All @@ -52,6 +52,7 @@ export default function Observations() {

const res = http.post(endpoint, JSON.stringify({ query, variables }), {
headers,
tags: { warmup: exec.scenario.iterationInTest === 0 ? "true" : "false" },
});

check(res, {
Expand All @@ -77,10 +78,16 @@ export default function Observations() {
}

export function handleSummary(data) {
if (durationExceedsThreshold(data.metrics.http_req_duration.values.avg)) {
const warmupMetrics = data.metrics["http_req_duration{warmup:true}"];
const actualMetrics = data.metrics["http_req_duration{warmup:false}"];
const avgDuration = actualMetrics
? actualMetrics.values.avg
: data.metrics.http_req_duration.values.avg;

if (durationExceedsThreshold(avgDuration)) {
return {
stdout: `${Math.round(
(100 * data.metrics.http_req_duration.values.avg) /
(100 * avgDuration) /
metadata.queries.DataCubeObservations.expectedDuration
)}% – DataCubeObservations – ${cubeLabel}. `,
};
Expand Down
14 changes: 10 additions & 4 deletions k6/performance-tests/graphql/DataCubePreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const variables = {

/** @type {import("k6/options").Options} */
export const options = {
iterations: 2,
iterations: 3,
};

const headers = {
Expand All @@ -51,6 +51,7 @@ export default function Components() {

const res = http.post(endpoint, JSON.stringify({ query, variables }), {
headers,
tags: { warmup: exec.scenario.iterationInTest === 0 ? "true" : "false" },
});

check(res, {
Expand Down Expand Up @@ -79,11 +80,16 @@ export default function Components() {
}

export function handleSummary(data) {
if (durationExceedsThreshold(data.metrics.http_req_duration.values.avg)) {
const warmupMetrics = data.metrics["http_req_duration{warmup:true}"];
const actualMetrics = data.metrics["http_req_duration{warmup:false}"];
const avgDuration = actualMetrics
? actualMetrics.values.avg
: data.metrics.http_req_duration.values.avg;

if (durationExceedsThreshold(avgDuration)) {
return {
stdout: `${Math.round(
(100 * data.metrics.http_req_duration.values.avg) /
metadata.queries.DataCubePreview.expectedDuration
(100 * avgDuration) / metadata.queries.DataCubePreview.expectedDuration
)}% – DataCubePreview – ${cubeLabel}. `,
};
}
Expand Down
14 changes: 10 additions & 4 deletions k6/performance-tests/graphql/PossibleFilters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const variables = {

/** @type {import("k6/options").Options} */
export const options = {
iterations: 2,
iterations: 3,
};

const headers = {
Expand All @@ -54,6 +54,7 @@ export default function Observations() {

const res = http.post(endpoint, JSON.stringify({ query, variables }), {
headers,
tags: { warmup: exec.scenario.iterationInTest === 0 ? "true" : "false" },
});

check(res, {
Expand All @@ -77,11 +78,16 @@ export default function Observations() {
}

export function handleSummary(data) {
if (durationExceedsThreshold(data.metrics.http_req_duration.values.avg)) {
const warmupMetrics = data.metrics["http_req_duration{warmup:true}"];
const actualMetrics = data.metrics["http_req_duration{warmup:false}"];
const avgDuration = actualMetrics
? actualMetrics.values.avg
: data.metrics.http_req_duration.values.avg;

if (durationExceedsThreshold(avgDuration)) {
return {
stdout: `${Math.round(
(100 * data.metrics.http_req_duration.values.avg) /
metadata.queries.PossibleFilters.expectedDuration
(100 * avgDuration) / metadata.queries.PossibleFilters.expectedDuration
)}% – PossibleFilters – ${cubeLabel}. `,
};
}
Expand Down