fix(rsc): use module export effect transform for `use server` file directive by hi-ogawa · Pull Request #1355 · vitejs/vite-plugin-react

hi-ogawa · 2026-07-30T06:02:02Z

part of Rework transformWrapExport and transformHoistInlineDirective #1350
part of Fix transformed Server Function source locations #1361
- mostly closes except Vite 8 inline directive case.

This PR adds transformModuleExportEffect for "use server" file directive transform. This simplifies the logic compared to previous transformWrapExport approach and allows aligning with Next.js better.

The substantial logic is duplicated from transformWrapExport and the parity is verified through tests. The unification of some logic is deferred to:

Co-authored-by: OpenCode <noreply@opencode.ai>

Co-authored-by: OpenCode <noreply@opencode.ai> # Conflicts: # packages/plugin-rsc/src/transforms/server-action.ts # packages/plugin-rsc/src/transforms/source-map.test.ts # packages/plugin-rsc/src/transforms/test-utils.ts

Co-authored-by: OpenCode <noreply@opencode.ai>

feat(rsc): add module export transform

4412003

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa commented Jul 30, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export.test.ts Outdated

Comment thread packages/plugin-rsc/src/transforms/module-export.test.ts Outdated

refactor(rsc): migrate module export transforms

e18a148

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa commented Jul 30, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export.ts Outdated

hi-ogawa commented Jul 30, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export.ts Outdated

hi-ogawa commented Jul 30, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export.ts Outdated

hi-ogawa changed the title ~~feat(rsc): add module export transform~~ feat(rsc): add new module export transform to retire transformWrapExport Jul 30, 2026

hi-ogawa commented Jul 30, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export.ts Outdated

hi-ogawa commented Jul 30, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/plugin.ts Outdated

hi-ogawa and others added 5 commits July 30, 2026 16:38

refactor(rsc): clarify module export transform types

6360351

Co-authored-by: OpenCode <noreply@opencode.ai>

docs(rsc): explain module export transform

7c52056

Co-authored-by: OpenCode <noreply@opencode.ai>

feat(rsc): return module export contexts

4d0b874

Co-authored-by: OpenCode <noreply@opencode.ai>

Merge branch 'main' into fix/issue-1350

fa56085

refactor(rsc): simplify multi-declarator exports

1ad2fae

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa commented Jul 30, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export.ts Outdated

hi-ogawa commented Jul 30, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export.test.ts Outdated

hi-ogawa and others added 2 commits July 31, 2026 13:03

Merge branch 'main' into fix/issue-1350

e5354dd

refactor(rsc): split module export models

ec8275e

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export.ts Outdated

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export.ts Outdated

hi-ogawa and others added 2 commits July 31, 2026 13:55

test(rsc): compare module export source maps

50ecb7d

Co-authored-by: OpenCode <noreply@opencode.ai>

refactor(rsc): simplify module export names

62ab0cc

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa mentioned this pull request Jul 31, 2026

test(rsc): test use server transform function name preservation #1366

Merged

hi-ogawa and others added 5 commits July 31, 2026 14:25

test(rsc): group module export source maps

d904947

Co-authored-by: OpenCode <noreply@opencode.ai>

Merge branch 'main' into fix/issue-1350

14afa60

refactor(rsc): allow mutable module exports

3c7641e

Co-authored-by: OpenCode <noreply@opencode.ai>

test(rsc): compare module export coverage

9bb4d95

Co-authored-by: OpenCode <noreply@opencode.ai>

fix(rsc): preserve module export effect mappings

18c328f

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa mentioned this pull request Jul 31, 2026

refactor(rsc): add transformModuleExportWrap and deprecate transformWrapExport #1370

Closed

3 tasks

Merge branch 'main' into fix/issue-1350

b5f3300

Co-authored-by: OpenCode <noreply@opencode.ai> # Conflicts: # packages/plugin-rsc/src/transforms/server-action.ts # packages/plugin-rsc/src/transforms/source-map.test.ts # packages/plugin-rsc/src/transforms/test-utils.ts

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export-effect.ts Outdated

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export-effect.ts

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export-effect.ts Outdated

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export-effect.test.ts Outdated

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export-effect.test.ts

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export-effect.ts

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export-effect.ts Outdated

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export-effect.ts Outdated

hi-ogawa commented Jul 31, 2026

View reviewed changes

Comment thread packages/plugin-rsc/src/transforms/module-export-effect.ts

hi-ogawa and others added 10 commits August 3, 2026 11:30

test(rsc): cover module export effect options

b6b983c

Co-authored-by: OpenCode <noreply@opencode.ai>

docs(rsc): note provisional export metadata

bd431a8

Co-authored-by: OpenCode <noreply@opencode.ai>

refactor(rsc): clarify module export effect types

36ac2a0

Co-authored-by: OpenCode <noreply@opencode.ai>

docs(rsc): clarify generated binding policy

0e482ce

Co-authored-by: OpenCode <noreply@opencode.ai>

nit

28fffba

refactor(rsc): align module export metadata

bf2bb69

Co-authored-by: OpenCode <noreply@opencode.ai>

docs(rsc): illustrate module export transform

871b125

Co-authored-by: OpenCode <noreply@opencode.ai>

test(rsc): clarify module export effect contract

d35e378

Co-authored-by: OpenCode <noreply@opencode.ai>

docs(rsc): explain module export effect flow

7fc1c91

Co-authored-by: OpenCode <noreply@opencode.ai>

test(rsc): reject string export names

c3219e6

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa mentioned this pull request Aug 3, 2026

test(rsc): invoke re-exported server reference #1376

Merged

hi-ogawa and others added 2 commits August 3, 2026 12:39

test(rsc): cover re-export import attributes

ea3699f

Co-authored-by: OpenCode <noreply@opencode.ai>

refactor(rsc): append export specifier effects

a12e3b0

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa marked this pull request as ready for review August 3, 2026 04:13

hi-ogawa and others added 3 commits August 3, 2026 13:13

docs(rsc): illustrate default export rewrites

ed99141

Co-authored-by: OpenCode <noreply@opencode.ai>

Merge branch 'main' into fix/issue-1350

975d557

Co-authored-by: OpenCode <noreply@opencode.ai>

test(rsc): update Vite 7 specifier locations

068bc05

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa merged commit 640d7d7 into main Aug 3, 2026
22 checks passed

hi-ogawa deleted the fix/issue-1350 branch August 3, 2026 04:43

hi-ogawa mentioned this pull request Aug 3, 2026

refactor(rsc): extract module export scan #1373

Merged

vite-release-bot Bot mentioned this pull request Aug 6, 2026

release: plugin-rsc@0.5.33 #1408

Merged

Navigation Menu

Uh oh!

Uh oh!

fix(rsc): use module export effect transform for `use server` file directive - #1355

fix(rsc): use module export effect transform for `use server` file directive#1355
hi-ogawa merged 42 commits into
mainfrom
fix/issue-1350

hi-ogawa commented Jul 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

hi-ogawa commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

hi-ogawa commented Jul 30, 2026 •

edited

Loading