fix(rsc): preserve fully filtered export groups - #1386
Closed
hi-ogawa wants to merge 10 commits into
Closed
Conversation
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai> # Conflicts: # packages/plugin-rsc/src/transforms/wrap-export.ts
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
changed the title
Contributor
Author
|
superseded by #1387 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1385.
transformWrapExportcurrently rewrites export syntax even when every export in a group is rejected by the filter. Depending on the export form, this can changeconsttolet, move declarations, introduce synthetic default bindings, or replace re-exports with imports and generated exports despite there being nothing to wrap.This evaluates each export filter once and leaves fully filtered declarations, variable declarations, specifier groups, re-exports, and default exports unchanged. Mixed groups still retain the existing rewrite behavior for selected exports. Filtered exports are not validated, generated, or reported.
Tests:
pnpm -C packages/plugin-rsc test --runpnpm -C packages/plugin-rsc tsc