perf: cache compiled RegExp for proxy context matching#22380
Open
tomohiro86 wants to merge 1 commit into
Open
Conversation
Regex patterns in `server.proxy` starting with `^` were compiled via `new RegExp(context)` on every incoming request. Pre-compile them once during `proxyMiddleware` initialization and reuse via a Map cache. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.proxycontexts starting with^were compiled vianew RegExp(context)on every incoming requestproxyMiddlewareinitialization and reuse via aMapcacheDetails
doesProxyContextMatchUrlwas called on every request for every proxy context. When a context started with^, it created a newRegExpobject each time — regex compilation is relatively expensive and the pattern never changes after config is loaded.The fix adds a
regexCache: Map<string, RegExp>insideproxyMiddlewarethat is populated when the proxy entries are initialized, and passes it down todoesProxyContextMatchUrl.Test plan
server.proxy: { '^/api': '...' }routes requests correctly