♻️ simplify dead code and test boundaries - #336
Merged
Conversation
Remove unused modules and no-op validators, trim implementation-detail tests, and move command coverage to real CLI and HTTP workflows. Keep the resulting suites focused on observable behavior and explicit external dependencies.
Restore the public Ember browser mapping export, remove an unused events-router export, and drop the internal TDD dependency-wiring test after the full simplification audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This codebase had gotten pretty bloated. We found production modules that nothing imported, CLI validators that always returned no errors, exports used only by tests, and a pile of tests that mostly proved mocks or asserted nothing (
assert.ok(true)included). That is a lot of maintenance cost without much confidence.What changed
browserMappingsexport after the final audit caught that@vizzly-testing/ember/testemexposes it.The goal here is not a better coverage number. The goal is tests that tell us when a user workflow broke. We kept the tests at the highest useful level and left the old mock-heavy suites behind.
Evidence
The root suite and every client suite pass. Storybook passes 172 tests, static-site passes 205, Ember passes 45, Vitest passes 23, and the reporter workflows pass 35 with 5 environment-appropriate skips. The build, published type checks, lint, formatting, and diff checks are clean. A final repository sweep found no remaining
assert.ok(true)tests, deleted-module references, or dangling references to the removed code.Follow-up
Real baseline-download success coverage and a few broader preview/upload failure scenarios would be useful in a separate boundary-focused test pass. I did not bring back the old broad mock suites just to fill those gaps.