Skip to content

[FEAT] add support for customiziable runtimeClass & podAnnotaions#958

Open
mahmoudk1000 wants to merge 2 commits into
vllm-project:mainfrom
mahmoudk1000:main
Open

[FEAT] add support for customiziable runtimeClass & podAnnotaions#958
mahmoudk1000 wants to merge 2 commits into
vllm-project:mainfrom
mahmoudk1000:main

Conversation

@mahmoudk1000
Copy link
Copy Markdown
Contributor

FILL IN THE PR DESCRIPTION HERE

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds RuntimeClass and PodAnnotations to the VLLMRuntime custom resource and updates the controller to propagate these settings to the Deployment. The review feedback points out typos in the new API fields, specifically RunetimeClass and nividia, which should be corrected. Additionally, the reviewer advised against using reflect.DeepEqual for pod annotations to avoid infinite reconciliation loops caused by external controllers, recommending a subset-based comparison instead.

Comment thread operator/api/v1alpha1/vllmruntime_types.go Outdated
Comment thread operator/internal/controller/vllmruntime_controller.go Outdated
Comment thread operator/internal/controller/vllmruntime_controller.go Outdated
Signed-off-by: Mahmoud Ayman <mahmoudk1000@gmail.com>
Signed-off-by: Mahmoud Ayman <mahmoudk1000@gmail.com>
@mahmoudk1000 mahmoudk1000 force-pushed the main branch 2 times, most recently from 98a7a44 to e5ede04 Compare May 25, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant