Fix Qwen3.5-Next RMSNormGated Initialization Error on TPU#37229
Fix Qwen3.5-Next RMSNormGated Initialization Error on TPU#37229jrplatin wants to merge 1 commit intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Code Review
This pull request resolves a TypeError encountered during the initialization of RMSNormGated for the Qwen3.5-Next model on TPUs. The issue stems from current_platform.current_device() returning None on this platform, leading to a crash. By removing the explicit device argument from the RMSNormGated constructor, the code now relies on PyTorch's default device handling, which is a more portable and robust approach. This change correctly fixes the initialization error without introducing side effects on other platforms.
|
Is making |
|
@yaochengji Yep good idea and will patch in TPU Inference, thanks! |
Purpose
Similar to #33501 -- fixes the following error seen on TPU:
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.