Skip to content

Added Batch for Windows Extraction (for easier of use)#3267

Open
TheSCREWEDSoftware wants to merge 2 commits intovmangos:developmentfrom
TheSCREWEDSoftware:extractor_batch
Open

Added Batch for Windows Extraction (for easier of use)#3267
TheSCREWEDSoftware wants to merge 2 commits intovmangos:developmentfrom
TheSCREWEDSoftware:extractor_batch

Conversation

@TheSCREWEDSoftware
Copy link
Copy Markdown

🍰 Pullrequest

Prior to this PR you would have to run each of them in order and 1 by 1 (MapExtractor, Vmap Extracotr, VampAssemeblr and than MMAP generator)

With this (gets copied with windows extractor tool if they ticked in cmake) and matter of moving the batch file alongside the exectuables

Proof

Extractor CLI
image

Without Extractors
image

With Extractors
Screenshot_1

https://github.com/Ryan-s-Projects/1.12.1-5875-Vanilla/releases/tag/Data
(this was the data extracted using the extractorBat + the extractors at the current pre-compiled binaries from release, based on a private server client (unsure if it's or not modified) but it's the proof it worked (the extraction).

Issues

  • None

How2Test

  • Be on windows
  • Tick the USE_EXTRACTORS
  • Compile
  • See the batch file with the extractors
  • Run the batch file with the extractors in the same place
  • See it working

Todo / Checklist

  • I don't use Linux but having a shell file equivalent for linux and mac (unsure if this supported by vmangos) woudln't be a bad addition.

TheSCREWEDSoftware and others added 2 commits March 19, 2026 11:08
Based on Kitzunu's original implemantion for AC

https: //github.com/azerothcore/azerothcore-wotlk/pull/5177
Co-Authored-By: Kitzunu <24550914+kitzunu@users.noreply.github.com>
)
if exist MoveMapGenerator.exe (
echo Extracting mmaps...
MoveMapGenerator.exe
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to pass --configInputPath and --offMeshInput here. E.g.:

MoveMapGenerator.exe --configInputPath "config.json" --offMeshInput "offmesh.txt"

(the files should be in ${BIN_DIR}/Extractors by default iirc, so the same directory as the extractor executables)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add an input to ask the files within the same directoy otherwise by default mmaps generator already uses them by default

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, I forgot because I install thise files to custom locations. 😄

Don't think it's necessary to prompt the user then.

@mserajnik
Copy link
Copy Markdown
Contributor

I don't use Linux but having a shell file equivalent for linux and mac (unsure if this supported by vmangos) woudln't be a bad addition.

I have this in my Docker setup, might serve as inspiration for a script.

@Daribon
Copy link
Copy Markdown
Contributor

Daribon commented Mar 19, 2026

I made a Linux extractor script myself a few months back (pre native merge):
https://gist.github.com/Daribon/03a696faf50c70ef692ca9803843d7ac#file-install-vmangos-sh-L328

It is very integrated with the entire install script I made, but it could be modified to be standalone.

@Daribon
Copy link
Copy Markdown
Contributor

Daribon commented Mar 19, 2026

I don't use Linux but having a shell file equivalent for linux and mac (unsure if this supported by vmangos) woudln't be a bad addition.

I have this in my Docker setup, might serve as inspiration for a script.

Already made new version, which grabs build number from the wow.exe, so user doesn't have to move the dbc files manually: https://gist.github.com/Daribon/4072493ffd0a4f2c6fc54a1895fdc743

Already tested and works as intended. It will extract maps, dbc, vmaps and mmaps.

With the power of ai slop, I also have a windows version of the above script:
https://gist.github.com/Daribon/f2148639837476d7b4f02153daf2d5b7
Untested, but probably works.

In none of the above scripts is mmaps optional, it is forced. However I could easily change it to ask the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants