Added Batch for Windows Extraction (for easier of use)#3267
Added Batch for Windows Extraction (for easier of use)#3267TheSCREWEDSoftware wants to merge 2 commits intovmangos:developmentfrom
Conversation
Based on Kitzunu's original implemantion for AC https: //github.com/azerothcore/azerothcore-wotlk/pull/5177 Co-Authored-By: Kitzunu <24550914+kitzunu@users.noreply.github.com>
| ) | ||
| if exist MoveMapGenerator.exe ( | ||
| echo Extracting mmaps... | ||
| MoveMapGenerator.exe |
There was a problem hiding this comment.
You might want to pass --configInputPath and --offMeshInput here. E.g.:
MoveMapGenerator.exe --configInputPath "config.json" --offMeshInput "offmesh.txt"(the files should be in ${BIN_DIR}/Extractors by default iirc, so the same directory as the extractor executables)
There was a problem hiding this comment.
Ah, right, I forgot because I install thise files to custom locations. 😄
Don't think it's necessary to prompt the user then.
I have this in my Docker setup, might serve as inspiration for a script. |
|
I made a Linux extractor script myself a few months back (pre native merge): It is very integrated with the entire install script I made, but it could be modified to be standalone. |
Already made new version, which grabs build number from the wow.exe, so user doesn't have to move the dbc files manually: https://gist.github.com/Daribon/4072493ffd0a4f2c6fc54a1895fdc743 Already tested and works as intended. It will extract maps, dbc, vmaps and mmaps. With the power of ai slop, I also have a windows version of the above script: In none of the above scripts is mmaps optional, it is forced. However I could easily change it to ask the user. |

🍰 Pullrequest
Prior to this PR you would have to run each of them in order and 1 by 1 (MapExtractor, Vmap Extracotr, VampAssemeblr and than MMAP generator)
With this (gets copied with windows extractor tool if they ticked in cmake) and matter of moving the batch file alongside the exectuables
Proof
Extractor CLI

Without Extractors

With Extractors

https://github.com/Ryan-s-Projects/1.12.1-5875-Vanilla/releases/tag/Data
(this was the data extracted using the extractorBat + the extractors at the current pre-compiled binaries from release, based on a private server client (unsure if it's or not modified) but it's the proof it worked (the extraction).
Issues
How2Test
Todo / Checklist