fix(compiler): use actual class declaration line number in debug info#169
Merged
Brooooooklyn merged 1 commit intovoidzero-dev:mainfrom Mar 26, 2026
Merged
Conversation
Shinigami92
force-pushed
the
fix-class-debug-line-number
branch
from
42cf549 to
32da404
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ɵsetClassDebugInfocall was hardcodinglineNumber: 1for all components. This was noted as a TODO in the codebase.The fix threads the source text into
compile_component_fulland computes the actual 1-indexed line number frommetadata.class_span.start.Snapshot updates reflect the corrected line numbers (e.g.
lineNumber:9,lineNumber:12,lineNumber:22). A few snapshots also picked up a minor formatting normalization frominsta(blank line after the---header) — no functional change.