fix(compiler): detect component context in compound track expressions#172
Open
ashley-hunter wants to merge 1 commit intovoidzero-dev:mainfrom
Open
fix(compiler): detect component context in compound track expressions#172ashley-hunter wants to merge 1 commit intovoidzero-dev:mainfrom
ashley-hunter wants to merge 1 commit intovoidzero-dev:mainfrom
Conversation
Track expressions using binary operators (??. +), ternary, or unary operators that referenced component members were incorrectly compiled as arrow functions, causing `this` to be undefined at runtime. The root cause was that `expression_contains_context` — a function not present in Angular's implementation — failed to traverse compound IR expression types like Binary and Ternary. Instead of patching every missing variant, this commit aligns with Angular's approach: detect ContextExpr during the transformExpressionsInExpression callback that already visits all expression types, setting usesComponentInstance in the same pass that replaces Context with TrackContext. This removes ~180 lines of redundant detection code (expression_contains_context, ast_contains_implicit_receiver) that duplicated work already done by resolve_names (phase 31) and the transform visitor. Output verified against the official Angular compiler (NgtscProgram) for all test cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track expressions using binary operators (??. +), ternary, or unary operators that referenced component members were incorrectly compiled as arrow functions, causing
thisto be undefined at runtime.The root cause was that
expression_contains_context— a function not present in Angular's implementation — failed to traverse compound IR expression types like Binary and Ternary. Instead of patching every missing variant, this commit aligns with Angular's approach: detect ContextExpr during the transformExpressionsInExpression callback that already visits all expression types, setting usesComponentInstance in the same pass that replaces Context with TrackContext.This removes ~180 lines of redundant detection code (expression_contains_context, ast_contains_implicit_receiver) that duplicated work already done by resolve_names and the transform visitor.
Output verified against the official Angular compiler for all test cases.