fix(jit): lower non-Angular decorators via __decorate#204
Merged
Brooooooklyn merged 1 commit intovoidzero-dev:mainfrom Apr 2, 2026
Merged
fix(jit): lower non-Angular decorators via __decorate#204Brooooooklyn merged 1 commit intovoidzero-dev:mainfrom
Brooooooklyn merged 1 commit intovoidzero-dev:mainfrom
Conversation
When a class has both Angular decorators (e.g. @Injectable) and non-Angular decorators (e.g. NGXS @State, @selector, @action), lower all decorators when converting class declarations to class expressions. Non-Angular member decorators are emitted as __decorate() calls matching TypeScript's tsc output: null for methods/accessors, void 0 for properties, instance members before static members.
8bb6930 to
72b7328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When @oxc-angular/vite encounters a class with both Angular and non-Angular decorators like @Injectable() and NGXS @State, @selector, or @action, it must lower all decorators – not just Angular ones – when converting class declarations to class expressions.
This PR: