fix: compile animation trigger host bindings to ɵɵsyntheticHostProperty#208
Merged
Brooooooklyn merged 2 commits intovoidzero-dev:mainfrom Apr 3, 2026
Merged
Conversation
…icHostProperty convert_animations_for_host was unconditionally converting all AnimationBindingOp entries to CreateOp::Animation (ɵɵanimateEnter/ɵɵanimateLeave), which is only correct for animate.enter/animate.leave bindings. Host [@trigger] bindings (AnimationBindingKind::Value) need to remain in the update list so they are reified as ɵɵsyntheticHostProperty in the rf & 2 block. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The directive's parse_host_property_name was missing the @ animation check,
causing host: { '[@slidein]': 'state' } on directives to emit ɵɵdomProperty
instead of ɵɵsyntheticHostProperty.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convert_animations_for_hostwas unconditionally converting allAnimationBindingOpentries toCreateOp::Animation(ɵɵanimateEnter/ɵɵanimateLeave), which is only correct foranimate.enter/animate.leave. Host[@trigger]bindings (AnimationBindingKind::Value) now stay in the update list and are reified asɵɵsyntheticHostProperty.parse_host_property_namewas missing the@animation check, causinghost: { '[@slideIn]': 'state' }on directives to emitɵɵdomPropertyinstead ofɵɵsyntheticHostProperty.Closes the issue where components with animation trigger host bindings like
host: { '[@slideIn]': 'animationState()' }would throwNG05105: Unexpected synthetic listenerat runtime because the animation trigger was silently dropped during compilation.Test plan
test_host_animation_trigger_bindingfor component host animation triggerstest_directive_host_animation_trigger_bindingfor directive host animation triggersanimation-host-property-trigger,animation-host-property-trigger-with-style,animation-directive-host-property-trigger)🤖 Generated with Claude Code