Skip to content

feat: allow explicitly disabling Vite+'s Node.js version management with node-version: off - #115

Open
KTrain5169 wants to merge 2 commits into
voidzero-dev:mainfrom
KTrain5169:vp-env-off
Open

feat: allow explicitly disabling Vite+'s Node.js version management with node-version: off#115
KTrain5169 wants to merge 2 commits into
voidzero-dev:mainfrom
KTrain5169:vp-env-off

Conversation

@KTrain5169

Copy link
Copy Markdown

A request from the Discord channel, this allows people who already use other systems to manage their Node version (such as Flox) to prevent Vite+ from messing with the used Node.js version.

I'm not quite sure if there's anything else to do, from the looks of it, it does seem so, but other pairs of eyes to look over this are appreciated.

Copilot AI review requested due to automatic review settings August 1, 2026 02:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for explicitly disabling Vite+ Node.js version management via the action input node-version: off, aimed at users who manage Node.js through other tooling.

Changes:

  • Update main action flow to treat node-version: off as a request to run vp env off.
  • Update action.yml input documentation to mention the off option.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/index.ts Adds nodeVersion !== "off" guard and an else if branch to run vp env off.
action.yml Updates node-version input description to mention off.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/index.ts
Comment thread action.yml
@fengmk2

fengmk2 commented Aug 3, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3376754c01

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread action.yml
Copilot AI review requested due to automatic review settings August 3, 2026 04:07
@KTrain5169

Copy link
Copy Markdown
Author

turns out I forgot to push my packed dist/index.mjs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

action.yml:25

  • The node-version input description still claims it "Defaults to Node.js latest LTS version", but there is no default: for this input and the action only manages Node when node-version (or node-version-file) is provided. Since this PR updates the description, it should accurately document the three states: unset (no Node management unless node-version-file is set), a version (runs vp env use), and off (runs vp env off).
    description: "Node.js version to install via `vp env use`. Defaults to Node.js latest LTS version. Pass `off` to disable."

@KTrain5169

Copy link
Copy Markdown
Author

waiting for merge ig

@fengmk2

fengmk2 commented Aug 3, 2026

Copy link
Copy Markdown
Member

@KTrain5169 Could you try this environment variable? It should be able to disable the Node.js version manager.

- uses: voidzero-dev/setup-vp@v1
  env:
    VP_NODE_MANAGER: "no"

@KTrain5169

Copy link
Copy Markdown
Author

@KTrain5169 Could you try this environment variable? It should be able to disable the Node.js version manager.

- uses: voidzero-dev/setup-vp@v1
  env:
    VP_NODE_MANAGER: "no"

will check later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants