Skip to content

fix: stop defaulting setup-ref/setupRef to the frozen v1 tag - #117

Merged
fengmk2 merged 1 commit into
mainfrom
fix-setup-ref-defaults
Aug 4, 2026
Merged

fix: stop defaulting setup-ref/setupRef to the frozen v1 tag#117
fengmk2 merged 1 commit into
mainfrom
fix-setup-ref-defaults

Conversation

@fengmk2

@fengmk2 fengmk2 commented Aug 4, 2026

Copy link
Copy Markdown
Member

Follow-up to #116 (now merged).

An unpinned setup-ref (GitLab) or setupRef (Azure) downloaded the compiled runtime from the moving v1 tag, which is now frozen at v1.15.0, so unpinned includes silently ran a stale v1.15.0 runtime.

  • Default setup-ref / setupRef (input default and bash env fallback) to v1.16.0, the latest release
  • Update the README input tables and the release checklist: the release PR now also bumps these defaults, so from v1.17.0 on the shipped template downloads the runtime of its own release
  • Update the src/azure/template.test.ts assertion

The README examples keep the explicit setup-ref pin, which is still the recommended setup and the only correct one for v1.16.0 itself (its shipped template default is the frozen v1).

@fengmk2
fengmk2 force-pushed the fix-setup-ref-defaults branch 2 times, most recently from 1664635 to 93004ee Compare August 4, 2026 04:22
fengmk2 added a commit that referenced this pull request Aug 4, 2026
The `v1` major tag is frozen at v1.15.0: the voidzero-dev org-level tag
ruleset blocks non-fast-forward tag updates, so it can no longer be
moved on each release. This PR restructures the docs around exact
version pinning.

- New `Versioning` section: pin an exact release tag (or commit SHA),
with a warning that `v1` is frozen at v1.15.0 and should not be used
- All GitHub, GitLab, and Azure examples now pin `v1.16.0`
- GitLab examples pin `setup-ref` to the same tag as the remote URL, so
the compiled runtime matches the included template; the separate
pinned-runtime section is folded into basic usage
- `package.json` version now tracks the latest release (bumped to
1.16.0); it was pinned at 1.0.0 when releases only moved tags
- Release steps updated: a PR bumps `package.json` and the README tags
before tagging, no `v1` move

Follow-up in #117 (stacked on this PR): the GitLab `setup-ref` and Azure
`setupRef` template defaults still fall back to the frozen `v1`, so an
unpinned include silently gets the v1.15.0 runtime.
Base automatically changed from docs/deprecate-v1-tag to main August 4, 2026 05:32
An unpinned setup-ref (GitLab) or setupRef (Azure) downloaded the
compiled runtime from the moving v1 tag, which is now frozen at
v1.15.0, so unpinned includes silently ran a stale runtime. Default
both to the latest release instead, and bump the defaults in each
release PR (added to the release checklist).
@fengmk2
fengmk2 force-pushed the fix-setup-ref-defaults branch from 93004ee to c15a5de Compare August 4, 2026 05:33
@fengmk2
fengmk2 marked this pull request as ready for review August 4, 2026 05:36
Copilot AI review requested due to automatic review settings August 4, 2026 05:36
@fengmk2
fengmk2 merged commit a3a544f into main Aug 4, 2026
43 checks passed
@fengmk2
fengmk2 deleted the fix-setup-ref-defaults branch August 4, 2026 05:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitLab and Azure pipeline templates to stop defaulting setup-ref / setupRef to the frozen v1 tag (v1.15.0), ensuring unpinned template usage pulls the intended compiled runtime for the template’s published release.

Changes:

  • Default setup-ref (GitLab) and setupRef (Azure) to v1.16.0 in the shipped templates (including the GitLab env fallback).
  • Update README input/parameter tables and the release checklist to reflect the new default-bump requirement per release.
  • Update src/azure/template.test.ts to assert the new Azure template default.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/azure/template.test.ts Updates the test expectation so the Azure template’s setupRef default matches the published template default (v1.16.0).
README.md Aligns docs and release checklist with the new template defaults and the “bump defaults per release” process.
gitlab/setup-vp.yml Changes setup-ref default and bash env fallback to v1.16.0 so unpinned includes don’t fetch the frozen v1 runtime.
azure/setup-vp.yml Changes setupRef parameter default to v1.16.0 so unpinned template usage pulls the correct runtime ref.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fengmk2 fengmk2 mentioned this pull request Aug 4, 2026
fengmk2 added a commit that referenced this pull request Aug 4, 2026
Bump the version to v1.16.1 in package.json, the README examples, and
the setup-ref / setupRef defaults in the GitLab and Azure templates.

Changes since v1.16.0:

- fix: stop defaulting setup-ref/setupRef to the frozen v1 tag (#117)
- docs: use exact version tags instead of the moving v1 tag (#116)

After merge, tag the merge commit as v1.16.1 and push the tag.

---------

Signed-off-by: MK (fengmk2) <fengmk2@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants