chore(tools): remove unused tool subcommands - #2324
Conversation
Both subcommands have no callers in the repo. The replace-file-content use case is already covered by the Rust vpt replace-file-content helper in crates/vite_cli_snapshots. The snap-tests fixtures under packages/tools/snap-tests had no runner wired to them.
✅ Deploy Preview for viteplus-preview canceled.
|
Like json-sort and replace-file-content, the TS json-edit has no callers; all live usage is the Rust vpt json-edit in crates/vite_cli_snapshots, which the interactive-snapshot-tests RFC introduced as its replacement.
jong-kyung
changed the title
jong-kyung
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad5752e5d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
reusable-release-build.yml runs 'pnpm exec json-edit' to stamp package versions during release and preview builds, so the workspace bin must stay until that workflow migrates to another helper.
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Description
Removes two dead subcommands from
@voidzero-dev/vite-plus-toolsand their orphaned snapshot fixtures.tool json-sortandtool replace-file-contenthave no callers anywhere in the repo, so this removes them along with their dispatch cases inindex.tsand the README entries.vpt replace-file-contenthelper incrates/vite_cli_snapshots.packages/tools/snap-tests/were only for these commands and had no runner wired to them, so the directory is removed entirely.packages/toolsREADME now documents the remainingtoolsubcommands (sync-remote,install-global-cli,brand-vite,local-npm-registry) instead of the removed ones.