fix(ipc): use named FIFOs for task communication on Unix - #569
Draft
wan9chi wants to merge 1 commit into
Draft
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
wan9chi
force-pushed
the
agent/reapply-runner-fifo
branch
from
July 30, 2026 06:12
d546ad9 to
6499a5c
Compare
fspy benchmarklinuxmacoswindows |
Member
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6499a5c73c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wan9chi
force-pushed
the
agent/reapply-runner-fifo
branch
11 times, most recently
from
July 31, 2026 07:09
b8e273e to
03e6984
Compare
wan9chi
force-pushed
the
fspy-sparse-file-shm
branch
from
August 4, 2026 10:17
c86913c to
8622417
Compare
wan9chi
force-pushed
the
agent/reapply-runner-fifo
branch
from
August 4, 2026 10:17
03e6984 to
3c21bcc
Compare
Default Codex CLI and Claude Code sandboxes block Unix domain sockets, so `vp run` failed while setting up task communication inside them. Replace the Unix transport with named FIFOs, which those sandboxes allow. The transport lives in the new `socket_ipc` crate: socket-style server-client IPC that carries no task-runner specifics. Windows keeps using named pipes. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
wan9chi
force-pushed
the
agent/reapply-runner-fifo
branch
from
August 4, 2026 10:21
3c21bcc to
833d8e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Codex CLI's and Claude Code's default sandboxes block Unix domain sockets, so
vp runfails while setting up task communication before any task code runs (#562). Named FIFOs are plain files, and both sandboxes allow them.This PR reapplies the FIFO transport from #565 with a rename, a review pass, and new coverage:
pipe_socket: socket-style server-client IPC, implemented on named pipes rather than Unix domain sockets. It carries no task-runner specifics, so it sits outside thevite_*prefix, likefspyandpty_terminal. It exposesServer::bind,Server::name,Server::accept, andClient::connect; FIFOs on Unix and named pipes on Windows stay implementation details.Client::connectnow fails instead of hanging when the server is gone. The rendezvous open is nonblocking, so a missing reader turns into a connection-refused error at once. While waiting for the server's ready byte, the client watches the rendezvous write end and probes the server every 100ms; a dead server turns into an error within one probe interval. macOS needs the probe because itspolldoes not always report FIFO events; Linux reports the death at once. The module documents the handshake step by step.codexCLI on macOS. The Claude sandbox snapshot is carried over from fix(ipc): use named FIFOs on Unix #565 unchanged; it needs ansrtbinary to regenerate, and the recorded behavior does not depend on the shared-memory backend that changed underneath it.Closes #562.
🤖 Generated with Claude Code