Open
Conversation
62280a5 to
f266c90
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
a10y
reviewed
Mar 23, 2026
a10y
reviewed
Mar 23, 2026
Contributor
Contributor
Author
|
I think in that case it is a struct, because they are named |
Contributor
Author
|
|
3d7ecb4 to
ad93dcf
Compare
AdamGS
added a commit
that referenced
this pull request
Mar 24, 2026
## Summary Filling up missing parts of making Variant a canonical array. It still not fully supported but this is a step towards it. These changes started as part of #7130, but I figured they are just noise in that already too big of a PR. ## API Changes Makes variant officially a canonical array and type. --------- Signed-off-by: Adam Gutglick <adam@spiraldb.com>
gatesn
reviewed
Mar 24, 2026
| arrow-buffer = { workspace = true } | ||
| arrow-schema = { workspace = true } | ||
| chrono = { workspace = true } | ||
| parquet-variant = { workspace = true } |
6e32d0f to
fbf4d4e
Compare
AdamGS
commented
Mar 25, 2026
| "vortex-jni", | ||
| "vortex-python", | ||
| "vortex-tui", | ||
| "vortex-sqllogictest", |
Contributor
Author
There was a problem hiding this comment.
just moving things around
fbf4d4e to
4848c82
Compare
gatesn
reviewed
Mar 25, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
510a8c8 to
e5a799e
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
e5a799e to
338af8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR introduces a new encoding to support Arrow's canonical extension type, but does not integrate it with anything else.
It does include basic pieces like slice/take/filter, and it can (or at least should) roundtrip with the equivalent arrow array.
Testing
The encoding includes a bunch of basic tests, both for making sure it roundtrips with arrow and for the various nullability cases.