fix(python): cap substrait-python before 0.29.0#7161
Merged
AdamGS merged 1 commit intovortex-data:developfrom Mar 25, 2026
Merged
fix(python): cap substrait-python before 0.29.0#7161AdamGS merged 1 commit intovortex-data:developfrom
AdamGS merged 1 commit intovortex-data:developfrom
Conversation
AdamGS
approved these changes
Mar 25, 2026
Contributor
|
Thank you for fixing things and also coming back! I should've looked closer at the original PR. |
Contributor
|
I think you need to signoff on your commit before I can merge it. |
Signed-off-by: Xu Che <chrisxuche@gmail.com>
RealXuChe
force-pushed
the
fix/substrait-pypi-upper-bound
branch
from
32dd37a to
81e87f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I made a mistake in #7153, for details about the mistake, see this comment: #7153 (comment)
This PR correctly fixes the
substrait-pythondependency problem.Testing
pip install vortex-data==0.64.0resolved tosubstrait==0.29.0,substrait-protobuf==0.85.0, andsubstrait-extensions==0.85.0, andimport vortexfailed.vortex-datafrom this PR branch resolved tosubstrait==0.28.0,substrait-protobuf==0.79.0, andsubstrait-extensions==0.79.0, andimport vortexsucceeded.