Fix streamhost default logging#1537
Open
jaketus wants to merge 1 commit intovoxpupuli:masterfrom
Open
Conversation
kenyon
approved these changes
Feb 18, 2023
Member
|
@jaketus can you please rebase against our latest master? |
|
How can we move on here? Can I help here? |
kenyon
force-pushed
the
patch-1
branch
2 times, most recently
from
a37119c to
01d1b7f
Compare
Current default values will cause Nginx to fail to start if nginx::stream is true. http://nginx.org/en/docs/stream/ngx_stream_log_module.html#access_log Format must be defined, which current default configuration doesn't do. Nginx default is "off", and therefore the module default should be "off" as well.
TheMeier
requested changes
Jun 4, 2025
Contributor
TheMeier
left a comment
TheMeier
left a comment
There was a problem hiding this comment.
the tests are failing but more important I think this is wrong. It produces something like this
access_log off stream_format;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Current default value for stream_access_log will cause Nginx to fail to start if nginx::stream is true.
http://nginx.org/en/docs/stream/ngx_stream_log_module.html#access_log
Format must be defined, which current default configuration doesn't do (since stream_custom_format_log is undef as well).
Nginx default is "off", and therefore the Puppet-module default should be "off" as well.
This Pull Request (PR) fixes the following issues