fix: pass format_html() placeholder args instead of pre-built strings - #6
Open
hafkensite wants to merge 1 commit into
Open
fix: pass format_html() placeholder args instead of pre-built strings#6hafkensite wants to merge 1 commit into
hafkensite wants to merge 1 commit into
Conversation
Django's format_html() now raises TypeError when called with no args/kwargs, since a caller building the whole string themselves defeats its escaping purpose. Affects every templatetag that used this pattern, breaking report/repo/host list pages. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format_html()now raisesTypeError: args or kwargs must be provided.when called with a single pre-formatted string and no placeholder args.format_html():yes_no_img/no_yes_img(util),yes_no_button_repo_en/yes_no_button_repo_sec(repos),report_alert(hosts) — breaking the reports, repos, and hosts list pages in production.format_htmlplaceholder args instead of pre-interpolating, which also restores proper autoescaping of those values.Test plan
/reports/and confirm the processed/not-processed icon column renders🤖 Generated with Claude Code