feat: add i18n/a11y localisation properties to select components#625
Open
wfabr wants to merge 1 commit into
Open
feat: add i18n/a11y localisation properties to select components#625wfabr wants to merge 1 commit into
wfabr wants to merge 1 commit into
Conversation
Member
|
Thanks! I'll go thorugh it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-visible strings and ARIA labels in the select components were hardcoded in English, which is an issue for translation. This pull request adds overridable properties with English defaults to
VscodeSelectBase,VscodeMultiSelect, andVscodeSingleSelect.New properties
VscodeSelectBase(inherited by both select components)open-button-aria-label— ARIA label on the combobox toggle button (default:"Open the list of options")no-options-text— empty-list placeholder (default:"No options")create-option-prefix— prefix for the creatable entry (default:"Add", renders asAdd "typed text")VscodeMultiSelectselected-text— suffix in the count badge (default:"Selected", renders as"3 Selected")select-all-title— tooltip on the select-all button (default:"Select all")deselect-all-title— tooltip on the deselect-all button (default:"Deselect all")accept-button-text— label on the OK button (default:"OK")Usage example
All defaults are unchanged so there is no breaking change.