VL_New-tailwind-colors_Vitalii-Dudnik#682
Merged
Merged
Conversation
| let cvaFn = cvaCache.get(key); | ||
|
|
||
| if (!cvaFn) { | ||
| // eslint-disable-next-line tailwindcss/no-custom-classname -- CVA config object, not a class string |
Contributor
There was a problem hiding this comment.
why this is required? any more clear solution?
…ind CSS file patterns in ESLint config
| settings: { | ||
| tailwindcss: { | ||
| cssConfigPath: "./src/tailwind.css", | ||
| functions: ["classnames", "classNames", "clsx", "ctl", "tv", "tw", "twJoin"], |
Contributor
There was a problem hiding this comment.
define only functions which really used in the project
Leave functions empty because cx, cva, and twMerge are only called with variables, not inline class strings. Parsing those helpers caused false positives from no-custom-classname while template classes remain linted.
KinduD21
commented
Jun 30, 2026
| tailwindcss: { | ||
| cssConfigPath: "./src/tailwind.css", | ||
| functions: ["classnames", "classNames", "clsx", "ctl", "tv", "tw", "twJoin"], | ||
| functions: [], |
Collaborator
Author
There was a problem hiding this comment.
If we drop functions entirely - we will get those linter warnings again, so this solution is explicit.
Contributor
There was a problem hiding this comment.
define only functions which really used in the project, not drop
itsJohnnyGrid
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded NEUTRAL_COLORS and updated type definitions to include new colors