fix(deps): bump @commitlint packages to v20#837
Open
jhoblitt wants to merge 1 commit into
Open
Conversation
commitlint 19 bundles conventional-commits-parser 5, which misparses a body line that begins with an issue reference as the start of the footer and raises a false footer-leading-blank error. commitlint 20 upgrades to conventional-commits-parser 6, which fixes that parse. Bump every @commitlint/* dependency from v19 to v20, and commitlint-plugin-function-rules to 4.3.2 for commitlint 20 peer compatibility. Node stays at 20.16.0; commitlint 20 requires only Node 18+. Refs: wagoid/commitlint-github-action#896 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump all
@commitlint/*dependencies from v19 to v20 (andcommitlint-plugin-function-rulesto4.3.2for peer compatibility), regeneratingpackage-lock.json.Why
commitlint 19 bundles
conventional-commits-parser@5.x, which misparses a commitbody line that begins with an issue reference (e.g.
#123) as the start of thefooter. With
footer-leading-blankenabled that yields a false positive, becausethe "footer" it invented is not preceded by a blank line.
Minimal repro (fails on the action as shipped,
wagoid/commitlint-github-action@v6.2.1):commitlint 20 upgrades the parser to
conventional-commits-parser@6.x, which parsesthis correctly. Verified locally: the same message fails under the bundled 19.8.1 and
passes under 20.5.3.
Upstream tracker: #896 (open since 2020); see also the reproduction in
conventional-changelog/commitlint#4099.
Why v20 and not v21
commitlint-plugin-function-rules@4.3.xdeclarespeerDependencies["@commitlint/lint"] = ">=19 <21", so it does not yet support commitlint 21 (that needs the plugin's v5line, which in turn requires commitlint 21 and drops <21). v20 is the highest release
compatible with the currently-pinned plugin.
Node
No Node change required. commitlint 20 only needs Node 18+; the repo's pinned
20.16.0(Dockerfile /.nvmrc/engines) already satisfies it.Verification
npm run build— oknpm test— 39/39 passnpm run lint(eslint) — cleanconventional-commits-parser@6.3.0under
@commitlint/parse@20.5.0