chore(docs): run visual regression in CI; align DatePicker text color#139
Open
wangdicoder wants to merge 1 commit into
Open
chore(docs): run visual regression in CI; align DatePicker text color#139wangdicoder wants to merge 1 commit into
wangdicoder wants to merge 1 commit into
Conversation
wangdicoder
force-pushed
the
feat/accessibility-improvements
branch
from
768d526 to
a1be4d6
Compare
wangdicoder
force-pushed
the
chore/visual-regression-and-theme
branch
from
89827bb to
9820aec
Compare
wangdicoder
force-pushed
the
feat/accessibility-improvements
branch
from
a1be4d6 to
f38b557
Compare
- Add `Visual regression tests` step to CI after the accessibility step introduced in #138. - Loosen visual regression tolerance from `maxDiffPixels: 100` to `maxDiffPixelRatio: 0.03` so subpixel anti-aliasing differences across rendering passes don't flake the suite. - Refresh recorded screenshots to match the DatePicker color change shipped in #138 and the Button demo retitle ("Type" → "Variant", "More Types" → "Semantic Colors").
wangdicoder
force-pushed
the
chore/visual-regression-and-theme
branch
from
9820aec to
7c17d02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual regression testsCI step (runningpnpm test:visual) after the accessibility step.--ty-picker-input-color-muted/--ty-date-picker-cell-color-mutedto--ty-color-text-secondary(with the previous token kept as a CSS fallback), so the date picker shares the same secondary-text token as the rest of the library.maxDiffPixels: 100tomaxDiffPixelRatio: 0.03to absorb subpixel rendering jitter.Test plan