feat: Add support for assigning numbers in beforeModuleIds hook#13222
feat: Add support for assigning numbers in beforeModuleIds hook#13222CPunisher merged 3 commits intoweb-infra-dev:mainfrom
beforeModuleIds hook#13222Conversation
beforeModuleIds hook
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dbab8476c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merging this PR will degrade performance by 36.91%🎉 Hooray!
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | js@collect imported identifiers |
210 µs | 212.4 µs | -1.16% |
| ❌ | Simulation | js@Traverse module graph by dependencies |
530.2 µs | 840.3 µs | -36.91% |
Comparing hamlim:hamlim/before-module-ids-hook (581bd06) with main (93cf488)
Footnotes
-
28 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
1dbab84 to
581bd06
Compare
Summary
This is a follow on change from this previous PR: #12809 which added support for assigning string values in the
beforeModuleIdshook, this PR extends that to support assigning numbers as well.This was highlighted in this PR comment here: #12809 (comment) as an enhancement to the existing logic.
Related links
Previous PR: #12809
Checklist