Skip to content

feat: Add support for assigning numbers in beforeModuleIds hook#13222

Merged
CPunisher merged 3 commits intoweb-infra-dev:mainfrom
hamlim:hamlim/before-module-ids-hook
Apr 9, 2026
Merged

feat: Add support for assigning numbers in beforeModuleIds hook#13222
CPunisher merged 3 commits intoweb-infra-dev:mainfrom
hamlim:hamlim/before-module-ids-hook

Conversation

@hamlim
Copy link
Copy Markdown
Contributor

@hamlim hamlim commented Mar 5, 2026

Summary

This is a follow on change from this previous PR: #12809 which added support for assigning string values in the beforeModuleIds hook, this PR extends that to support assigning numbers as well.

This was highlighted in this PR comment here: #12809 (comment) as an enhancement to the existing logic.

Related links

Previous PR: #12809

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@hamlim hamlim requested a review from hardfist as a code owner March 5, 2026 16:26
@hamlim hamlim changed the title feat: Add support for assigning numbers in beforeModuleIds hook feat: Add support for assigning numbers in beforeModuleIds hook Mar 5, 2026
@hamlim hamlim mentioned this pull request Mar 5, 2026
2 tasks
@hardfist
Copy link
Copy Markdown
Contributor

hardfist commented Mar 6, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1dbab8476c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/rspack_binding_api/src/plugins/interceptor.rs Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 6, 2026

Merging this PR will degrade performance by 36.91%

🎉 Hooray! codspeed-node just leveled up to 5.2.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

❌ 2 regressed benchmarks
✅ 7 untouched benchmarks
⏩ 28 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation js@collect imported identifiers 210 µs 212.4 µs -1.16%
Simulation js@Traverse module graph by dependencies 530.2 µs 840.3 µs -36.91%

Comparing hamlim:hamlim/before-module-ids-hook (581bd06) with main (93cf488)

Open in CodSpeed

Footnotes

  1. 28 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@CPunisher CPunisher force-pushed the hamlim/before-module-ids-hook branch from 1dbab84 to 581bd06 Compare April 9, 2026 07:33
Copy link
Copy Markdown
Contributor

@CPunisher CPunisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CPunisher CPunisher merged commit 4dba376 into web-infra-dev:main Apr 9, 2026
74 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants