feat!: disable mergeDuplicateChunks in development mode#13319
Closed
feat!: disable mergeDuplicateChunks in development mode#13319
Conversation
github-actions
Bot
added
the
team
hardfist
changed the title
github-actions
Bot
added
the
release: feature
Contributor
Rsdoctor Bundle Diff Analysis
Found 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Rspack’s default for optimization.mergeDuplicateChunks to be mode-dependent, aligning defaults/docs/types/tests with the new behavior (disabled in development, enabled in production).
Changes:
- Change
optimization.mergeDuplicateChunksdefault tofalsein development andtrueotherwise (including production/default mode). - Update English/Chinese docs to show mode-specific defaults for
mergeDuplicateChunks. - Update defaults test snapshots for development-mode expectations (including related optimization defaults shown in snapshots).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/config/optimization.mdx | Document mode-dependent defaults for optimization.mergeDuplicateChunks in Chinese docs. |
| website/docs/en/config/optimization.mdx | Document mode-dependent defaults for optimization.mergeDuplicateChunks in English docs. |
| tests/rspack-test/defaultsCases/mode/development.js | Update development-mode defaults snapshot expectations, including mergeDuplicateChunks: false. |
| tests/rspack-test/defaultsCases/cache/cache-filesystem-dev.js | Update development + persistent cache defaults snapshot expectations, including mergeDuplicateChunks: false. |
| packages/rspack/src/config/types.ts | Update type docs to describe the mode-dependent default behavior (production vs development). |
| packages/rspack/src/config/defaults.ts | Implement the mode-dependent default via factory defaulting (F(..., () => !development)). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 49.01MB |
Contributor
|
📝 Benchmark detail: Open
Threshold exceeded: ["arco-pro_development-mode + exec"] |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Deploying rspack with
|
| Latest commit: |
3514fb6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd827b25.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-development-mergedupli.rspack-v2.pages.dev |
Contributor
|
📝 Benchmark detail: Open
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimization.mergeDuplicateChunksdefault tofalsein development mode andtruein productionTesting